refactor logger in linef

[imago.git] / imago_pack / linef.py

diff --git a/imago_pack/linef.py b/imago_pack/linef.py
index 4e35781..667442c 100644 (file)
--- a/imago_pack/linef.py
+++ b/imago_pack/linef.py
@@ -1,5 +1,6 @@
-"""Go image recognition lines-finding module"""
+"""Lines finding module."""

 
 

+from functools import partial

 import sys
 from math import sin, cos, pi
 
 import sys
 from math import sin, cos, pi
 


@@ -12,70 +13,74 @@ except ImportError, msg:
 import filters
 from hough import Hough
 
 import filters
 from hough import Hough
 

-def find_lines(image, show_all, do_something, verbose):
-
-    if verbose:
-        print >> sys.stderr, "preprocessing"
-
-    if show_all:
-        do_something(image, "original image")
-
+def prepare(image, show_image, logger):
+    # TODO comment

     im_l = image.convert('L')
     im_l = image.convert('L')

-    if show_all:
-        do_something(im_l, "ITU-R 601-2 luma transform")
-
-    if verbose:
-        print >> sys.stderr, "edge detection"
+    show_image(im_l, "ITU-R 601-2 luma transform")

 
 

+    logger("edge detection")

     im_edges = filters.edge_detection(im_l)
     im_edges = filters.edge_detection(im_l)

-    if show_all:    
-        do_something(im_edges, "edge detection")
+    show_image(im_edges, "edge detection")

 
     im_h = filters.high_pass(im_edges, 100)
 
     im_h = filters.high_pass(im_edges, 100)

-    if show_all:
-        do_something(im_h, "high pass filters")
-    
-    if verbose:
-        print >> sys.stderr, "hough transform"
+    show_image(im_h, "high pass filters")

 
 

-    hough1 = Hough(im_h.size)
-    im_hough = hough1.transform(im_h)
-    if show_all:
-        do_something(im_hough, "hough transform")
+    return im_h
+ 
+def transform(image, hough, show_image):
+    # TODO comment
+    im_hough = hough.transform(image)
+    show_image(im_hough, "hough transform")

 
 

-   # im_hough = filters.peaks(im_hough)
-   # if show_all:
-   #     do_something(im_hough, "peak extraction")
+   # im_hough.image = filters.peaks(im_hough.image)
+   # show_image(im_hough.image, "peak extraction")

                
     im_h2 = filters.high_pass(im_hough, 96)
                
     im_h2 = filters.high_pass(im_hough, 96)

-    if show_all:
-        do_something(im_h2, "second high pass filters")
+    show_image(im_h2, "second high pass filters")

 
     im_h2 = filters.components2(im_h2)
 
     im_h2 = filters.components2(im_h2)

-    if show_all:
-        do_something(im_h2, "components centers")
+    show_image(im_h2, "components centers")
+
+    return im_h2

 
 

+def find_lines(image, show_image, verbose):
+    """Find lines in the *image*."""
+    # TODO refactor into smaller functions
+    

     if verbose:
     if verbose:

-        print >> sys.stderr, "second hough transform"
+        def logger(m):
+            print >> sys.stderr, m
+    else:
+        def logger(m):
+            pass
+        
+    logger("preprocessing")
+    show_image(image, "original image")
+
+    im_h = prepare(image, show_image, logger)
+
+    hough = Hough.default(im_h)
+
+    logger("hough transform")
+    
+    im_h2 = transform(im_h, hough, show_image)
+
+    logger("second hough transform")

 
 

-    hough2 = Hough(im_h2.size) 

     # im_hough might be used instead im_h2, but at the moment it brings a lot of
     # noise to the second transform, which later confuses the center-finding
     # mechanism (which is not very robust yet)
     # im_hough might be used instead im_h2, but at the moment it brings a lot of
     # noise to the second transform, which later confuses the center-finding
     # mechanism (which is not very robust yet)

+    hough2 = Hough.default(im_h2)

     im_hough2 = hough2.transform(im_h2)
     im_hough2 = hough2.transform(im_h2)

-    if show_all:
-        do_something(im_hough2, "second hough transform")
+    show_image(im_hough2, "second hough transform")

 
     im_h3 = filters.high_pass(im_hough2, 120)
 
     im_h3 = filters.high_pass(im_hough2, 120)

-    if show_all:
-        do_something(im_h3, "third high pass filter")
+    show_image(im_h3, "third high pass filter")

      
     im_h3 = filters.components(im_h3)
      
     im_h3 = filters.components(im_h3)

-    if show_all:
-        do_something(im_h3, "half centers")
+    show_image(im_h3, "half centers")

 
 

-    if verbose:
-        print >> sys.stderr, "finding the grid"
+    logger("finding the grid")

 
     lines_m = hough2.all_lines_h(im_h3)
     lines = []
 
     lines_m = hough2.all_lines_h(im_h3)
     lines = []


@@ -89,29 +94,29 @@ def find_lines(image, show_all, do_something, verbose):
         line_points = set()
         for line in line_l:
             draw.line(line_from_angl_dist(line, im_h2.size), fill=255, width=7)
         line_points = set()
         for line in line_l:
             draw.line(line_from_angl_dist(line, im_h2.size), fill=255, width=7)

-            draw_c.line(line_from_angl_dist(line, im_c.size), fill=(70, 70, 70), width=7)
+            draw_c.line(line_from_angl_dist(line, im_c.size),
+                        fill=(70, 70, 70), width=7)

             for p in combine(im_h2, im_line):
                 line_points.add(p)
         for point in line_points:
             draw_c.point(point, fill=(120, 255, 120))
             for p in combine(im_h2, im_line):
                 line_points.add(p)
         for point in line_points:
             draw_c.point(point, fill=(120, 255, 120))

-        lines.append(hough1.lines_from_list(line_points))
+        lines.append(hough.lines_from_list(line_points))

         line_points = list(line_points)
         line_points.sort()
         bounds += [line_points[0], line_points[-1]]
 
         line_points = list(line_points)
         line_points.sort()
         bounds += [line_points[0], line_points[-1]]
 

-    if show_all:
-        do_something(im_c, "hough x lines")
+    show_image(im_c, "hough x lines")

 
     image_g = image.copy()
     draw = ImageDraw.Draw(image_g)
     for line in [l for s in lines for l in s]:
         draw.line(line_from_angl_dist(line, image.size), fill=(120, 255, 120))
 
     image_g = image.copy()
     draw = ImageDraw.Draw(image_g)
     for line in [l for s in lines for l in s]:
         draw.line(line_from_angl_dist(line, image.size), fill=(120, 255, 120))

-    if show_all:
-        do_something(image_g, "lines")
+    show_image(image_g, "lines")

    
    

-    return lines, lines_m[0][0], lines_m[1][0], bounds, hough1, im_h
+    return lines, lines_m[0][0], lines_m[1][0], bounds, hough

 
 def combine(image1, image2):
 
 def combine(image1, image2):

+    """Return a list of points that are present in both images."""

     im_l1 = image1.load()
     im_l2 = image2.load()
 
     im_l1 = image1.load()
     im_l2 = image2.load()
 


@@ -124,6 +129,8 @@ def combine(image1, image2):
     return on_both
 
 def line_from_angl_dist((angle, distance), size):
     return on_both
 
 def line_from_angl_dist((angle, distance), size):

+    """Take *angle* and *distance* (from the center of the image) of a line and
+    size of the image. Return the line represented by two points."""

     if pi / 4 < angle < 3 * pi / 4:
         y1 = - size[1] / 2
         x1 = int(round((y1 * cos(angle) + distance) / sin(angle))) + size[0] / 2
     if pi / 4 < angle < 3 * pi / 4:
         y1 = - size[1] / 2
         x1 = int(round((y1 * cos(angle) + distance) / sin(angle))) + size[0] / 2