comments to the specification

[imago.git] / src / intrsc.py

diff --git a/src/intrsc.py b/src/intrsc.py
index 355468c..68b18a0 100644 (file)
--- a/src/intrsc.py
+++ b/src/intrsc.py
@@ -8,6 +8,7 @@ import ImageDraw
 import filters
 import k_means
 import output
 import filters
 import k_means
 import output

+import linef

 
 def dst(line):
     """Return normalized line."""
 
 def dst(line):
     """Return normalized line."""


@@ -29,6 +30,11 @@ def board(image, lines, show_all, do_something):
     # TODO refactor show_all, do_something
     # TODO refactor this into smaller functions
     lines = [dst_sort(l) for l in lines]
     # TODO refactor show_all, do_something
     # TODO refactor this into smaller functions
     lines = [dst_sort(l) for l in lines]

+    an0 = (sum([l[0] for l in lines[0]]) / len(lines[0]) - pi / 2)
+    an1 = (sum([l[0] for l in lines[1]]) / len(lines[1]) - pi / 2)
+    if an0 > an1:
+        lines = [lines[1], lines[0]]
+

     intersections = intersections_from_angl_dist(lines, image.size)
 
     if show_all:
     intersections = intersections_from_angl_dist(lines, image.size)
 
     if show_all:


@@ -112,28 +118,37 @@ def board(image, lines, show_all, do_something):
     return output.Board(19, board_r)
 
 def mean_luma(cluster):
     return output.Board(19, board_r)
 
 def mean_luma(cluster):

-    """Return mean luma of the *cluster* of points."""
+    """Return mean luminanace of the *cluster* of points."""

     return sum(c[0][0] for c in cluster) / float(len(cluster))
 
     return sum(c[0][0] for c in cluster) / float(len(cluster))
 

+def to_general(line, size):
+    # TODO comment
+    (x1, y1), (x2, y2) = linef.line_from_angl_dist(line, size)
+    return (y2 - y1, x1 - x2, x2 * y1 - x1 * y2)
+
+def intersection(l1, l2):
+    a1, b1, c1 = l1
+    a2, b2, c2 = l2
+    delim = float(a1 * b2 - b1 * a2)
+    x = (b1 * c2 - c1 * b2) / delim
+    y = (c1 * a2 - a1 * c2) / delim
+    return x, y
+
+# TODO remove the parameter get_all

 def intersections_from_angl_dist(lines, size, get_all=True):
     """Take grid-lines and size of the image. Return intersections."""
 def intersections_from_angl_dist(lines, size, get_all=True):
     """Take grid-lines and size of the image. Return intersections."""

+    lines0 = map(lambda l: to_general(l, size), lines[0])
+    lines1 = map(lambda l: to_general(l, size), lines[1])

     intersections = []
     intersections = []

-    for (angl1, dist1) in lines[1]:
+    for l1 in lines1:

         line = []
         line = []

-        for (angl2, dist2) in lines[0]:
-            if abs(angl1 - angl2) > 0.4:
-                i_x =  (- ((dist2 / cos(angl2)) - (dist1 / cos(angl1))) 
-                        / (tan(angl1) - tan(angl2)))
-                i_y = (tan(angl1) * i_x) - (dist1 / cos(angl1))
-                if get_all or (-size[0] / 2 < i_x < size[0] / 2 and 
-                    -size[1] / 2 < i_y < size[1] / 2):
-                    line.append((int(i_x + size[0] / 2),
-                                 int(i_y + size[1] / 2)))
+        for l2 in lines0:
+            line.append(intersection(l1, l2))

         intersections.append(line)
     return intersections
    
 def rgb2lumsat(color):
         intersections.append(line)
     return intersections
    
 def rgb2lumsat(color):

-    """Convert RGB to luma and HSI model saturation."""
+    """Convert RGB to luminance and HSI model saturation."""

     r, g, b = color
     luma = (0.30 * r + 0.59 * g + 0.11 * b) / 255.0
     max_diff = max(color) - min(color)
     r, g, b = color
     luma = (0.30 * r + 0.59 * g + 0.11 * b) / 255.0
     max_diff = max(color) - min(color)


@@ -162,6 +177,8 @@ def stone_color_raw(image, (x, y)):
             except IndexError:
                 pass
     norm = float(len(points))
             except IndexError:
                 pass
     norm = float(len(points))

+    if norm == 0:
+        return 0, 0, (0, 0, 0) #TODO trow exception here

     color = (sum(p[0] for p in points) / norm,
              sum(p[1] for p in points) / norm,
              sum(p[2] for p in points) / norm)
     color = (sum(p[0] for p in points) / norm,
              sum(p[1] for p in points) / norm,
              sum(p[2] for p in points) / norm)